Skip to content

[release-4.19] OCPBUGS-60682: certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

[release-4.19] OCPBUGS-60682: certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle #861

merged 1 commit into from
Sep 15, 2025
+5 −4

Conversation

vrutkovs
Copy link
Member

This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode

@vrutkovs
certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle
6841675 
This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode
@vrutkovs
Copy link
Member Author

/jira cherrypick OCPBUGS-60473

@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-60473 has been cloned as Jira Issue OCPBUGS-60682. Will retitle bug to link to clone.
/retitle OCPBUGS-60682: Missing endpoint slices for open ports the operator uses

In response to this:

/jira cherrypick OCPBUGS-60473

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title Missing endpoint slices for open ports the operator uses OCPBUGS-60682: Missing endpoint slices for open ports the operator uses Aug 20, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 20, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-60473 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs changed the title OCPBUGS-60682: Missing endpoint slices for open ports the operator uses OCPBUGS-60682: [release-4.19] certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle Aug 20, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 20, 2025

@vrutkovs: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60473 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60473 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60473 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs changed the title OCPBUGS-60682: [release-4.19] certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle [release-4.19] OCPBUGS-55217: certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle Sep 15, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-55217, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20" instead
  • expected Jira Issue OCPBUGS-55217 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-55217, which is invalid:

  • expected the bug to target either version "4.19." or "openshift-4.19.", but it targets "4.20" instead
  • expected Jira Issue OCPBUGS-55217 to depend on a bug targeting a version in 4.20.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs vrutkovs changed the title [release-4.19] OCPBUGS-55217: certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle [release-4.19] OCPBUGS-60682: certrotationcontroller: set RefreshOnlyWhenExpired for CA bundle Sep 15, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is invalid:

  • expected dependent Jira Issue OCPBUGS-60473 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Duplicate) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vrutkovs
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Sep 15, 2025
@openshift-ci-robot
Copy link

@vrutkovs: This pull request references Jira Issue OCPBUGS-60682, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-60473 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-60473 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 15, 2025
@openshift-ci openshift-ci bot requested a review from xingxingxia September 15, 2025 06:53
@ricardomaraschini
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2025
@wangke19
Copy link

/verified later by @wangke19

@openshift-ci-robot
Copy link

@wangke19: Only users can be targets for the /verified later command.

In response to this:

/verified later by @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

/verified later @wangke19

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 15, 2025
@openshift-ci-robot
Copy link

@wangke19: This PR has been marked to be verified later by @wangke19.

In response to this:

/verified later @wangke19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ingvagabund
Copy link
Member

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 15, 2025
@ingvagabund
Copy link
Member

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, ricardomaraschini, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 15, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 5bc489f into openshift:release-4.19 Sep 15, 2025
12 checks passed
@openshift-ci-robot
Copy link

@vrutkovs: Jira Issue OCPBUGS-60682: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-60682 has not been moved to the MODIFIED state.

This PR is marked as verified-later. Jira issue(s) in the title of this PR will require post-merge verification. After testing, it must be manually moved to the VERIFIED state.

In response to this:

This prevents CA bundle from being updated by sidecar running in RefreshOnlyWhenExpired=true mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-kube-controller-manager-operator
This PR has been included in build ose-cluster-kube-controller-manager-operator-container-v4.19.0-202509151437.p0.g5bc489f.assembly.stream.el9.
All builds following this will include this PR.

This was referenced Sep 26, 2025
Merged
Merged
@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.20.0-0.nightly-2025-09-27-153025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atiratree atiratree Awaiting requested review from atiratree

@ingvagabund ingvagabund Awaiting requested review from ingvagabund

@xingxingxia xingxingxia Awaiting requested review from xingxingxia

Assignees

@ricardomaraschini ricardomaraschini

@zhouying7780 zhouying7780

@xingxingxia xingxingxia

@wangke19 wangke19

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@vrutkovs @openshift-ci-robot @ricardomaraschini @wangke19 @ingvagabund @openshift-bot @openshift-merge-robot @zhouying7780 @xingxingxia